Skip to content

Commit

Permalink
tests(smokehouse): disable multiple shadow root deprecation test (#3695)
Browse files Browse the repository at this point in the history
  • Loading branch information
brendankenny authored Oct 31, 2017
1 parent 6c9f717 commit efe0e48
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
4 changes: 3 additions & 1 deletion lighthouse-cli/test/fixtures/dobetterweb/dbw_tester.js
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,9 @@ if (location.search === '' || params.has('passiveEvents')) {
if (location.search === '' || params.has('deprecations')) {
const div = document.createElement('div');
div.createShadowRoot();
div.createShadowRoot(); // FAIL - multiple shadow v0 roots.
// FAIL(errors-in-console) - multiple shadow v0 roots.
// TODO: disabled until m64 is stable (when moved from deprecation warning to error)
// div.createShadowRoot();
}

})();
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ module.exports = [
audits: {
'errors-in-console': {
score: false,
// TODO: should be 5 after m64 (see note in dbw_tester.js)
rawValue: 4,
displayValue: '4',
details: {
Expand Down Expand Up @@ -168,12 +169,12 @@ module.exports = [
score: false,
extendedInfo: {
value: {
length: 4,
length: 3,
},
},
details: {
items: {
length: 4,
length: 3,
},
},
},
Expand Down

0 comments on commit efe0e48

Please sign in to comment.