feedback

GoogleChrome · May 4, 2017 · f12c6a8 · f12c6a8
1 parent b2b18fe
commit f12c6a8
Show file tree

Hide file tree

Showing 7 changed files with 23 additions and 15 deletions.
diff --git a/lighthouse-core/audits/audit.js b/lighthouse-core/audits/audit.js
@@ -70,7 +70,7 @@ class Audit {
    * Table cells will use the type specified in headings[x].itemType. However a custom type
    * can be provided: results[x].propName = {type: 'code', text: '...'}
    * @param {!Audit.Headings} headings
-   * @param {!Array<!Object<string, string>>} results
+   * @param {!Array<!Object<string, *>>} results
    * @return {!Array<!DetailsRenderer.DetailsJSON>}
    */
   static makeV2TableRows(headings, results) {
@@ -157,13 +157,20 @@ class Audit {
 
 module.exports = Audit;
 
+/** @typedef {
+ * !Array<{
+ *   key: string,
+ *   itemType: string,
+ *   text: string,
+ * }>}
+ */
+Audit.Headings; // eslint-disable-line no-unused-expressions
+
 /** @typedef {{
- *     key: string,
- *     itemType: string,
- *     text: string,
+ *   results: !Array<!Object<string, string>>,
+ *   headings: !Audit.Headings,
+ *   passes: boolean,
+ *   debugString: (string|undefined)
  * }}
  */
-Audit.Heading; // eslint-disable-line no-unused-expressions
-
-/** @typedef {!Array<!Audit.Heading>} */
-Audit.Headings; // eslint-disable-line no-unused-expressions
+Audit.HeadingsResult; // eslint-disable-line no-unused-expressions
diff --git a/lighthouse-core/audits/byte-efficiency/byte-efficiency-audit.js b/lighthouse-core/audits/byte-efficiency/byte-efficiency-audit.js
@@ -69,8 +69,7 @@ class UnusedBytes extends Audit {
   }
 
   /**
-   * @param {!{debugString: string=, passes: boolean=, headings: !Audit.Headings,
-   *    results: !Array<!Object<string, string>>}} result
+   * @param {!Audit.HeadingsResult} result
    * @param {number} networkThroughput
    * @return {!AuditResult}
    */

diff --git a/lighthouse-core/audits/byte-efficiency/offscreen-images.js b/lighthouse-core/audits/byte-efficiency/offscreen-images.js
@@ -96,7 +96,7 @@ class OffscreenImages extends ByteEfficiencyAudit {
 
   /**
    * @param {!Artifacts} artifacts
-   * @return {{results: !Array<Object>, headings: !Audit.Headings, debugString: string=}}
+   * @return {!Audit.HeadingsResult}
    */
   static audit_(artifacts) {
     const images = artifacts.ImageUsage;

diff --git a/lighthouse-core/audits/byte-efficiency/uses-optimized-images.js b/lighthouse-core/audits/byte-efficiency/uses-optimized-images.js
@@ -63,7 +63,7 @@ class UsesOptimizedImages extends ByteEfficiencyAudit {
 
   /**
    * @param {!Artifacts} artifacts
-   * @return {{results: !Array<Object>, headings: !Audit.Headings, passes: boolean=, debugString: string=}}
+   * @return {!Audit.HeadingsResult}
    */
   static audit_(artifacts) {
     const images = artifacts.OptimizedImages;

diff --git a/lighthouse-core/audits/byte-efficiency/uses-request-compression.js b/lighthouse-core/audits/byte-efficiency/uses-request-compression.js
@@ -47,7 +47,7 @@ class ResponsesAreCompressed extends ByteEfficiencyAudit {
   /**
    * @param {!Artifacts} artifacts
    * @param {number} networkThroughput
-   * @return {{results: !Array<Object>, passes: boolean=, headings: !Audit.Headings, debugString: string=}}
+   * @return {!Audit.HeadingsResult}
    */
   static audit_(artifacts) {
     const uncompressedResponses = artifacts.ResponseCompression;

diff --git a/lighthouse-core/audits/byte-efficiency/uses-responsive-images.js b/lighthouse-core/audits/byte-efficiency/uses-responsive-images.js
@@ -81,7 +81,7 @@ class UsesResponsiveImages extends ByteEfficiencyAudit {
 
   /**
    * @param {!Artifacts} artifacts
-   * @return {{results: !Array<Object>, headings: !Audit.Headings, passes: boolean=, debugString: string=}}
+   * @return {!Audit.HeadingsResult}
    */
   static audit_(artifacts) {
     const images = artifacts.ImageUsage;

diff --git a/lighthouse-core/report/v2/renderer/details-renderer.js b/lighthouse-core/report/v2/renderer/details-renderer.js
@@ -70,6 +70,8 @@ class DetailsRenderer {
   }
 
   /**
+   * Create small thumbnail with scaled down image asset.
+   * If the supplied details doesn't have an image/* mimeType, then an empty span is returned.
    * @param {!DetailsRenderer.ThumbnailDetails} value
    * @return {!Element}
    */
@@ -80,7 +82,7 @@ class DetailsRenderer {
 
     const element = this._dom.createElement('img', 'lh-thumbnail');
     element.src = value.url;
-    element.alt = 'Image preview';
+    element.alt = '';
     element.title = value.url;
     return element;
   }