core: save native HTMLElement.prototype.matches function to avoid con…

…flict (#5934)_
GoogleChrome · Oct 15, 2018 · f984ab1 · f984ab1
1 parent 2b12fc2
commit f984ab1
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/lighthouse-core/gather/driver.js b/lighthouse-core/gather/driver.js
@@ -1137,7 +1137,8 @@ class Driver {
   async cacheNatives() {
     await this.evaluateScriptOnNewDocument(`window.__nativePromise = Promise;
         window.__nativeError = Error;
-        window.__nativeURL = URL;`);
+        window.__nativeURL = URL;
+        HTMLElement.prototype.__matches = HTMLElement.prototype.matches;`);
   }
 
   /**

diff --git a/lighthouse-core/lib/page-functions.js b/lighthouse-core/lib/page-functions.js
@@ -90,7 +90,7 @@ function getElementsInDocument(selector) {
   /** @param {NodeListOf<Element>} nodes */
   const _findAllElements = nodes => {
     for (let i = 0, el; el = nodes[i]; ++i) {
-      if (!selector || el.matches(selector)) {
+      if (!selector || el.__matches(selector)) {
         results.push(el);
       }
       // If the element has a shadow root, dig deeper.