Lighthouse 2.0.0 FF issues

[XhmikosR]

I'm using Firefox 54 beta on Windows 7 64-bit

1. Some of the new SVG icons don't show up here
2. The score on the sidebar shows NaN

[patrickhulce]

re-opening for the second half of this issue that wasn't addressed by #2361 "Some of the new SVG icons don't show up here"

[evenstensberg]

I'll pick it up tomorrow, sorry!

[evenstensberg]

Last item to fix is the bugs due to details and summary in firefox, where chrome uses ::-webkit-details-marker to completely forget about this issue

[XhmikosR]

@ev1stensberg: can't we do what the MDN article suggests? https://developer.mozilla.org/en/docs/Web/HTML/Element/details

[evenstensberg]

I was actually tempted to correct the manual audits class in <summary> to be compliant to the passed audits, in order to at least make the colors depend, instead of implicitly. Regardless, this is an issue with ::-webkit-details-marker and list-item styling that differs in chrome from FF.

[evenstensberg]

Actually, let me take the first things I said back. We use the psudo-element to style. In firefox, doesn't seem to work cause display doesn't get updated / ::-webkit-details-marker doesn't apply the marker changes, as we've disabled the native bullet point/arrow. This is a hack ❌

[evenstensberg]

Could we move this to #2385 ?

[XhmikosR]

I haven't verified with the latest master myself. If you confirm only this is left feel free to close.

…

On May 30, 2017 21:50, "Even Stensberg" ***@***.***> wrote: Could we move this to #2385 <#2385> ? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2320 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAVVtVdsr2-9nMvtO7GVv63DrwILuYyYks5r_GTWgaJpZM4NhWyo> .