Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit Closure annotations for codebase #358

Closed
samthor opened this issue May 25, 2016 · 7 comments
Closed

Audit Closure annotations for codebase #358

samthor opened this issue May 25, 2016 · 7 comments
Assignees
@samthor

Comments

@samthor
Copy link
Contributor

samthor commented May 25, 2016

Let's check the codebase for type annotation completeness.
@samthor samthor self-assigned this May 25, 2016
@brendankenny
Copy link
Member

brendankenny commented May 25, 2016 •
edited
Loading

currently files are whitelisted for type checking here

@paullewis
Copy link
Contributor

Hero

@wardpeet
Copy link
Collaborator

so just remove them from whitelist and start fixing through pr?

@paulirish
Copy link
Member

@samthor any update on this?

@samthor
Copy link
Contributor Author

samthor commented Jun 10, 2016

See #360.

Then I went on holidays. I'm back next week.

@paulirish
Copy link
Member

sup!

@paulirish
Copy link
Member

closing to keep our issues focused

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samthor samthor

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@paulirish @samthor @brendankenny @paullewis @wardpeet