get closure-type-checking running again #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samthor
force-pushed
the
closure-fix
branch
2 times, most recently
from
5842496 to
30f3793
Compare
| @@ -1,6 +1,6 @@ | |||
| language: node_js | |||
| node_js: | |||
| - "5.0" | |||
| - "5.1" | |||
There was a problem hiding this comment.
ah, if this was for the build failure, this won't help :) Rest parameters were added in 6
There was a problem hiding this comment.
Fixed this in the method.
|
reviewed! Current build failure should be fixed by not using rest parameters while we still support node 5. |
|
@brendankenny this should be good to go now. I've got more fixes in a follow-up patch. |
|
nice job! LGTM |
| @@ -206,7 +206,7 @@ class Aggregate { | |||
| // TODO(paullewis): Remove once coming soon audits have landed. | |||
| if (expected[e].comingSoon) { | |||
| subItems.push({ | |||
| value: String.raw`¯\_(ツ)_/¯`, | |||
| value: '¯\\_(ツ)_/¯', // TODO(samthor): Patch going to Closure, String.raw is badly typed | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@brendankenny
This gets us up and running again, at least with warnings, not errors.
This works around #954 in an interesting way, but I have some thoughts on fixing that properly too.