-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce the size of the trace #3596
Comments
We might want to revisit priority of this since it's responsible for ~10% failure rate on WPT |
This feels like it's moving towards a world where catapult and lighthouse are less similar, which is seems like a step backwards to me. Can we accomplish the same goal by splitting some trace categories into finer grained sub-categories? |
The long term goal was to enable many of Lighthouse insights on all page runs, not just ones where we can capture a trace. In a way, this is much more aligned with native implementation of TTI. The short-term goal and realistic version of this is exactly what you describe, moving/copying critical trace events to their own smaller category such that we don't need everything under the sun. |
Sound good. For metrics like TTI in particular, long term we hope to just spit out the final values into the trace. Perhaps these final values should be in their own trace category? |
What fraction of toplevel is |
Should the title of this issue be something like "Shrink set of required trace events", or similar? |
Here's a 74 mb trace of theverge loading with lighthouse's categories: In the script, i separated ProcessTaskFromWorkQueue into its own category, so the topmost
probably. right now its including both 1) moving things from the trace to the protocol and 2) shrinking the trace update feb 2018: CL to tweak trace event category: https://chromium-review.googlesource.com/c/chromium/src/+/791314 |
CL updated: https://chromium-review.googlesource.com/c/chromium/src/+/791314 I think we can also get rid of the 'loading' category. probably others. |
As of r588753 (m71), there's a new event for scheduleable tasks. we can now drop toplevel, and add the new category.
https://bugs.chromium.org/p/chromium/issues/detail?id=874982#c14 |
just landed:
The two of these dropped one site's trace from 110MB to 48MB. That definitely is the low hanging fruit. There are probably 2 more obvious improvements we could make. First, here's what's taking up space (top events, then top categories):
That's all that stands out to me, the next biggest things don't seem worth it to deal with. |
We're good for now here. Biggest next item is throttling the screenshots, tracked by #4713 |
Tracing causes many sites on WPT to crash Chrome on the phone. Reducing the required number of categories or streaming these few necessary events is the only path forward to making these failure go away.
Lantern relies heavily on quite a few trace events, isolating the key events necessary, and migrating those to Audits.* domain events to eliminate the need for tracing could be helpful since a majority of time spent is in trace parsingThe text was updated successfully, but these errors were encountered: