Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hanging trace retrieval on LR #5968

Closed
paulirish opened this issue Sep 5, 2018 · 1 comment · Fixed by #6056
Closed

Hanging trace retrieval on LR #5968

paulirish opened this issue Sep 5, 2018 · 1 comment · Fixed by #6056
Assignees
@paulirish @exterkamp
Labels
needs-investigation P1

Comments

@paulirish
Copy link
Member

paulirish commented Sep 5, 2018 •
edited
Loading

We have evidence that the loop of _readTraceFromStream() is stalling out and hanging indefinitely.

  1. we might want to add some timeouts
  2. we could experiment with not using a stream (in the LR case)
  3. trace reduction Reduce the size of the trace #3596 will help but probably not fix
@paulirish paulirish self-assigned this Sep 5, 2018
@wardpeet
Copy link
Collaborator

When looking at parse time we could go try out https://github.com/mafintosh/turbo-json-parse to see if it helps.

@exterkamp exterkamp self-assigned this Sep 18, 2018
@exterkamp exterkamp mentioned this issue Sep 19, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paulirish paulirish

@exterkamp exterkamp

Labels
needs-investigation P1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

core(driver): deliver trace as events rather than a stream GoogleChrome/lighthouse
3 participants
@paulirish @wardpeet @exterkamp