Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid properties found: {"viewport-fit":"cover"}. #3771

Closed
krabbypattified opened this issue Nov 7, 2017 · 2 comments · Fixed by #4382
Closed

Invalid properties found: {"viewport-fit":"cover"}. #3771

krabbypattified opened this issue Nov 7, 2017 · 2 comments · Fixed by #4382
Labels
bug P1
Milestone
Sprint Ocho: Janu...

Comments

@krabbypattified
Copy link

This is an iOS optimization. Why should this make me fail the PWA checklist?
@patrickhulce
Copy link
Collaborator

Thanks for raising this @krabbypattified! Seems to be a new case of #2474.

We might want to consider a looser approach to the meta viewport parser instead of playing iOS whack-a-mole.

@paulirish paulirish mentioned this issue Jan 29, 2018
Merged
@dickeylth
Copy link

As of current latest lighthouse version 2.8.0, the issue still occurs in the SEO part of the report:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug P1
Projects
None yet
Milestone
Sprint Ocho: January 29 - Feb 9
Development

Successfully merging a pull request may close this issue.

deps: bump metaviewport-parser to 0.2.0 GoogleChrome/lighthouse
4 participants
@paulirish @dickeylth @patrickhulce @krabbypattified