Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appveyor smoke tests are flaky #4891

Closed
patrickhulce opened this issue Mar 29, 2018 · 0 comments · Fixed by #4933
Closed

Appveyor smoke tests are flaky #4891

patrickhulce opened this issue Mar 29, 2018 · 0 comments · Fixed by #4933
Assignees

Comments

@patrickhulce
Copy link
Collaborator

Appveyor only passes the byte-efficiency smoke tests ~80% of the time (2 of last 10 builds on master have failed, and anecdotally it feels like lots of my PRs get red status checks).

It's going to be difficult to get consistent results on appveyor since we discovered how crazy variable their CPU performance is, we might want to loosen our expectations on smokehouse just in appveyor/run multiple times/adjust estimate if we detect very slow CPU/etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant