Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core(lantern): more flexible graph edge creation #4933

Merged
merged 5 commits into from
Apr 10, 2018
Merged

Conversation

patrickhulce
Copy link
Collaborator

@patrickhulce patrickhulce commented Apr 5, 2018

closes #4891

this should fix the appveyor flakiness we've been seeing which was 3-pronged

  • generic variability on the image wastedMs assertions, if Chrome doesn't load the images fast enough the graph won't necessarily have them loading at the same time either. adjusting some of the expectations fixes this
  • appveyor is helllllla slow already and throttling made this even worse, CPU throttling is now disabled for appveyor
  • appveyor is so slow that it takes too long for chrome to mark that a network request finished such that the script may have already started executing and the edge was excluded from the graph. the lantern side fix addresses this along with some tests

also I made smokehouse a bit more debuggable by using output-path for the JSON instead of stdout and adding a ENV variable to print stdout

@patrickhulce patrickhulce changed the title [WIP] tests: deflake appveyor core(lantern): more flexible graph edge creation Apr 6, 2018
Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me. Great 🗺🔍🕵️ work

}

if (process.env.APPVEYOR) {
// Appveyor is hella slow already, disable CPU throttling so we're not 16x slowdown
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe link to #4891?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 done

Copy link
Member

@paulirish paulirish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm % nit

const command = 'node';
const args = [
'lighthouse-cli/index.js',
url,
`--config-path=${configPath}`,
`--output-path=smokehouse.report.json`,
Copy link
Member

@paulirish paulirish Apr 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I often run yarn smokehouse and yarn smoke simultaneously which could conflict in this scenario.

also my smokehouse revamp PR means we'll have a lot of these running at the same time.

how about something like:

const filename = `smokehouse${Math.round(Math.random()*1000))}.report.json`;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we go down this path, can we delete the report by default then? :P

@paulirish paulirish merged commit a6a9fc1 into master Apr 10, 2018
@paulirish paulirish deleted the appveyor_flake branch April 10, 2018 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Appveyor smoke tests are flaky
4 participants