-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PROTOCOL_TIMEOUT (Method: Page.getAppManifest) #7147
Comments
Thanks for filing @curtchan! I'm able to reproduce this as described on web.dev/PSI and not the CLI 👍 |
@patrickhulce sorry, by CLI i meant pagespeed's api endpoint - |
Experiencing this issue on: https://my-project-75792.firebaseapp.com/ |
Here's my manifest:
|
I experienced it
This is a page that uses:
So the o role of websockets is important. |
PSI runs LH on infrastructure that does not yet support certain types of requests:
I know for certain that the first type has never worked. I assumed the second didn't either, @curtchan are you certain that v5 of PSI at one point didn't return AFAIU the third is a huge task and there are no plans currently to implement. Relevant issue for this in our repo: #6566 |
Yeah @hoten we now always try to fetch the manifest, not just in the gatherer! I didn't realize calling |
Luckily it seems if the page does not have a manifest, Chrome will return from the This is probably serious enough to consider a quick fix + PSI push. Let's discuss in chat. |
Determined that #7147 (comment) is a bit wrong. App manifest files are served just fine in our infra. The problem sites all have websockets - currently their mere existence on a page causes PSI to hang. That certainly is not ideal, and while we may not be able to fully support them yet, we should prioritize preventing a hang. |
Dug in a bit more. A page can actually use WebSockets (although a connection will always fail). The issue looks to be the long polling. I made a minimal repro here: http://uninterested-badge.surge.sh/index4.html Without the manifest file, PSI runs fine (no protocol timeout). With the manifest file, it times out. internal bug: b/124008171 |
@hoten tested again via api explorer for v5:
It clearly returns server 500 error. |
Can also reproduce on https://www.toyota.com/camry/ and https://www.toyota.com/ (both of which have a websocket) |
@hoten Let's fix in LH and push to LR prod.... on Friday? :) Or.. Thursday! |
New issue to track the failure without the timeout? |
Deployed to PageSpeed Insights production. Toyota now works (usually) |
@brendankenny I confirmed. In my case, it works. Thank you @hoten and @paulirish. |
The same here http://77.68.7.68/ |
Provide the steps to reproduce
https://seo4.net
orhttps://krakowskakancelaria.pl/
What is the current behavior?
Error: Lighthouse returned error: PROTOCOL_TIMEOUT. Waiting for DevTools protocol response has exceeded the allotted time. (Method: Page.getAppManifest) (PROTOCOL_TIMEOUT)
What is the expected behavior?
No errors.
Environment Information
Extra info
Issues started to occur since thursday, no action were performed on website, we tried modifying appmanifest but it doesn't seem to be the issue as it is valid and working.
~100 other websites we are tracking regularly do have manifest and they work fine.
The text was updated successfully, but these errors were encountered: