Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smokehouse tests do not fail on finalUrl/errorCode mismatches #7225

Closed
connorjclark opened this issue Feb 12, 2019 · 0 comments
Closed

Smokehouse tests do not fail on finalUrl/errorCode mismatches #7225

connorjclark opened this issue Feb 12, 2019 · 0 comments
Assignees

Comments

@connorjclark
Copy link
Collaborator

connorjclark commented Feb 12, 2019

diff --git a/lighthouse-cli/test/smokehouse/pwa-expectations.js b/lighthouse-cli/test/smokehouse/pwa-expectations.js
index 9db56360..3ebd2c37 100644
--- a/lighthouse-cli/test/smokehouse/pwa-expectations.js
+++ b/lighthouse-cli/test/smokehouse/pwa-expectations.js
@@ -24,7 +24,7 @@ const pwaDetailsExpectations = {
 module.exports = [
   {
     requestedUrl: 'https://airhorner.com',
-    finalUrl: 'https://airhorner.com/',
+    finalUrl: 'https://airhorner.com/asdasdasdas',
     audits: {
       'is-on-https': {
         score: 1,

image

Note that the status code is 0.

This is due to the way errors are counted in smokehouse.js report().

@connorjclark connorjclark self-assigned this Feb 12, 2019
@connorjclark connorjclark changed the title Smokehouse tests don't fail if only final url / error code is wrong Smokehouse tests do not fail on finalUrl/errorCode mismatches Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants