Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does Lighthouse run the entire aXe core or just part of it? #7510

Closed
susanlynnholland opened this issue Mar 14, 2019 · 6 comments
Closed

Does Lighthouse run the entire aXe core or just part of it? #7510

susanlynnholland opened this issue Mar 14, 2019 · 6 comments

Comments

@susanlynnholland
Copy link

Does Lighthouse run the entire aXe core or just part of it?

@patrickhulce
Copy link
Collaborator

We run all wcag2a, wcag2aa tagged rules with a few specific ones turned off.

return window.axe.run(document, {
elementRef: true,
runOnly: {
type: 'tag',
values: [
'wcag2a',
'wcag2aa',
],
},
resultTypes: ['violations', 'inapplicable'],
rules: {
'tabindex': {enabled: true},
'accesskeys': {enabled: true},
'table-fake-caption': {enabled: false},
'td-has-header': {enabled: false},
'marquee': {enabled: false},
'area-alt': {enabled: false},
'blink': {enabled: false},
'server-side-image-map': {enabled: false},
},
// @ts-ignore
}).then(axeResult => {

@susanlynnholland
Copy link
Author

susanlynnholland commented Mar 14, 2019 via email

@patrickhulce
Copy link
Collaborator

patrickhulce commented Mar 14, 2019

There was discussion in #6169, basically we don't get useful results from them and they were potentially expensive to compute.

I'm going to go ahead and close this since it seems answered but feel free to reopen if you think there's an issue here.

@susanlynnholland
Copy link
Author

susanlynnholland commented Mar 14, 2019 via email

@missmatsuko
Copy link

Hi, does anyone have more information about the reasons why these rules were disabled?

I looked through the disabled rules. A few look like they're for deprecated elements (e.g. marquee, blink), and a few look redundant (e.g. duplicate-id-active, duplicate-id-aria), but there's still a few that seem pretty critical and relevant even for modern websites.

In particular:

The only reasons I could find for removing these tests were that they weren't displayed in results and/or they're computationally expensive.

If these tests are important, they should be run and displayed by default.

If they're not important, please give provide a reason.

@paulirish
Copy link
Member

paulirish commented Sep 14, 2020

table-fake-caption

the implementation from axe doesn't make a significant test here. it's fairly handwavy in determining pass/fail.

td-has-header

the implementation is far too costly. it could be sped up with a better algorithm, but until that's done, we can't incur the cost of it. see dequelabs/axe-core#908 if users want this check, they can use the axe extension

aria-hidden-body
form-field-multiple-labels

both of these rules are enabled and reported in lighthouse


also cc evaluate new axe audits for inclusion · Issue #7127 and Clean up aXe audits · Issue #6169

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants