-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does Lighthouse run the entire aXe core or just part of it? #7510
Comments
We run all wcag2a, wcag2aa tagged rules with a few specific ones turned off. lighthouse/lighthouse-core/gather/gatherers/accessibility.js Lines 24 to 45 in b548452
|
Thank you! Out of curiosity, why were those in particular turned off?
…On Thu, Mar 14, 2019 at 2:07 PM Patrick Hulce ***@***.***> wrote:
We run all wcag2a, wcag2aa tagged rules with a few specific ones turned
off.
https://github.com/GoogleChrome/lighthouse/blob/b548452d8b0c3903d30c0effee0e10649ac8f5e6/lighthouse-core/gather/gatherers/accessibility.js#L24-L45
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#7510 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AUARlUMYWVgXQ31YdjhiuHYZuVocXUaVks5vWo_ngaJpZM4b0qHd>
.
--
*Susan L. Holland*
*Quality Assurance Analyst*
*sholland@techdynamism.com <sholland@techdynamism.com>*
*w: 434-227-5324, x. 132*
*c: 434-249-0995*
|
There was discussion in #6169, basically we don't get useful results from them and they were potentially expensive to compute. I'm going to go ahead and close this since it seems answered but feel free to reopen if you think there's an issue here. |
Thanks!
…On Thu, Mar 14, 2019 at 2:21 PM Patrick Hulce ***@***.***> wrote:
There was discussion in #6169
<#6169>, basically we
get useful results from them and they were potentially expensive to compute.
I'm going to go ahead and close this since it seems answered but feel free
to reopen if you think there's an issue here.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#7510 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AUARldNMD2AlYqzsvWcxI_9T7R9JisRyks5vWpM7gaJpZM4b0qHd>
.
--
*Susan L. Holland*
*Quality Assurance Analyst*
*sholland@techdynamism.com <sholland@techdynamism.com>*
*w: 434-227-5324, x. 132*
*c: 434-249-0995*
|
Hi, does anyone have more information about the reasons why these rules were disabled? I looked through the disabled rules. A few look like they're for deprecated elements (e.g. marquee, blink), and a few look redundant (e.g. duplicate-id-active, duplicate-id-aria), but there's still a few that seem pretty critical and relevant even for modern websites. In particular: The only reasons I could find for removing these tests were that they weren't displayed in results and/or they're computationally expensive. If these tests are important, they should be run and displayed by default. If they're not important, please give provide a reason. |
the implementation from axe doesn't make a significant test here. it's fairly handwavy in determining pass/fail.
the implementation is far too costly. it could be sped up with a better algorithm, but until that's done, we can't incur the cost of it. see dequelabs/axe-core#908 if users want this check, they can use the axe extension
both of these rules are enabled and reported in lighthouse also cc evaluate new axe audits for inclusion · Issue #7127 and Clean up aXe audits · Issue #6169 |
Does Lighthouse run the entire aXe core or just part of it?
The text was updated successfully, but these errors were encountered: