Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch DevTools to use emulatedFormFactor for Desktop testing #8967

Closed
halilozanyilmaz opened this issue May 16, 2019 · 8 comments
Closed

Switch DevTools to use emulatedFormFactor for Desktop testing #8967

halilozanyilmaz opened this issue May 16, 2019 · 8 comments

Comments

@halilozanyilmaz
Copy link

halilozanyilmaz commented May 16, 2019

Version: (Please someone P.S me how to find the version of lighhouse. I use chrome audit section)

Provide the steps to reproduce

  1. Run LH SEO test on the following page: tisort.ist/buyuk-beden-tisort/

What is the current behavior?

Gives this message:
Tap targets are not sized appropriately
62% appropriately sized tap targets
Interactive elements like buttons and links should be large enough (48x48px), and have enough space around them, to be easy enough to tap without overlapping onto other elements. Learn more.

What is the expected behavior?

Pass the audit

I don't understand why it gives this message: Here is the screenshot. I am highlighing one of the links that lighhouse compailing about.

Edit: I realized that it is doing this on "Desktop" test. Which caused me to be confused. Why would it be testing mobile requirements when "desktop" test is selected?

image

@patrickhulce
Copy link
Collaborator

Thanks for filing @halilozanyilmaz!

I wonder if we should reword our audit description to be less mobile-only focused if the size of clickable targets is still a UX concern for desktop as well

cc @mattzeunert @AVGP for their take on SEO-impact on desktop of appropriately sized UI targets.

@halilozanyilmaz
Copy link
Author

halilozanyilmaz commented May 16, 2019

@patrickhulce ,

This error is for my desktop site:

Make sure your pages are mobile friendly so users don’t have to pinch or zoom in order to read the content pages.

But my site has mobile view already, I mean instead of changing the wording, this audit should be canceled.

Because if a website's mobile view passes this audit, then desktop view should not be audited for this item, because it will not be seen by a mobile device. (Of course mobile devices has "view as desktop" for browsing options, but I don't think it should be considered for audit)

@patrickhulce
Copy link
Collaborator

@halilozanyilmaz are you talking about font size now? That should already be marked as not applicable if it was tested as desktop on latest version of lighthouse (not yet in Audits panel, coming soon). If you can reproduce that behavior with the latest version of CLI or Extension please file a separate bug.

@halilozanyilmaz
Copy link
Author

@patrickhulce , no I am not talking abou the font size. I tested my SEO for page in "Desktop" mode, and the error says my pages are not mobile friendly (the above screenshot). However If I would have tested in "Mobile" mode, it would work fine. So in above post I was saying that, maybe for desktop test, this error about if pages are okay for mobile can be canceled. Anyways I fixed my site for this, so it won't be possible to reproduce error on my site. But this is something general I think.

@patrickhulce
Copy link
Collaborator

Oh the Mobile Friendly SEO group as a whole?

Yeah seems fair to make all audits in that group not-applicable when not on mobile or move them into a more generic group @mattzeunert. WDYT?

@mattzeunert
Copy link
Contributor

Yeah, they should be not applicable, I think it's an issue with how DevTools calls Lighthouse.

DevTools uses disableDeviceEmulation rather than emulatedFormFactor. (disableDeviceEmulation was also recently removed, but Chrome stable is still on 4.2.0.)

TestedAsMobileDevice ends up being true – not 100% sure but maybe because emulatedFormFactor defaults to mobile?

So the solution will be to specify emulatedFormFactor in Chrome.

@patrickhulce patrickhulce changed the title Tap targets are not sized appropriately Tap targets are not sized appropriately should be notApplicable on DevTools Desktop May 21, 2019
@brendankenny brendankenny changed the title Tap targets are not sized appropriately should be notApplicable on DevTools Desktop Switch DevTools to use emulatedFormFactor for Desktop testing Jun 26, 2019
@connorjclark
Copy link
Collaborator

I think this was fixed in Chrome 77. @halilozanyilmaz, can you confirm with your site?

@patrickhulce
Copy link
Collaborator

Confirmed this is fixed for the reported URL in Chrome Canary.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants