core: remove disableDeviceEmulation flag #8289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wardpeet
requested review from
brendankenny,
patrickhulce and
paulirish
as code owners
wardpeet
changed the title
patrickhulce
suggested changes
Apr 15, 2019
There was a problem hiding this comment.
Thanks @wardpeet! I think we have a few more stragglers around :)
|
🤦♂️ sorry, I fixed it. I was so focused on the javascript flag and not considering the cli flag. |
8 tasks
patrickhulce
approved these changes
Apr 16, 2019
|
I could add the deprecation and move this one to version 6? As I don't think it's worth it. It's a major bump but it's always nice to tell people what's going away. |
|
@wardpeet oh yeah I was thinking if anything we cherry-pick a deprecation notice onto 4.3 for a final patch release or something, agreed not worth bumping to v6 👍 |
|
oh yeah let me create a small PR for it. |
| @@ -123,7 +122,7 @@ function getFlags(manualArgv) { | |||
|
|
|||
| // boolean values | |||
| .boolean([ | |||
| 'disable-storage-reset', 'disable-device-emulation', 'save-assets', 'list-all-audits', | |||
brendankenny
approved these changes
Apr 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove disableDeviceEmulation flag and fore people on emulatedFormFactor
Related Issues/PRs
closes #7044