Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all element attributes for the MetaElements artifacts #9964

Closed
roelfjan opened this issue Nov 12, 2019 · 2 comments · Fixed by #9978
Closed

Add all element attributes for the MetaElements artifacts #9964

roelfjan opened this issue Nov 12, 2019 · 2 comments · Fixed by #9978

Comments

@roelfjan
Copy link
Contributor

Feature request summary
Now for the MetaElements artifact the properties name and content are provided (see: types). I would like to get all attributes on the <meta> element.

Facebook uses the attribute property instead of name for their tags, like this:

<meta property="og:description" content="[description]" />

Which results in the MetaElements like this:

 { name: "", content: "[description]" }

I would like to receive something like this for a Facebook meta tag:

 { property: "og:description", content: "[description]" }

What is the motivation or use case for changing this?
I am creating a Lighthouse plugin for an audit on social sharing tags like Twitter and Facebook present on the page. This feature is needed for a check on Facebook tags.

How is this beneficial to Lighthouse?
This feature provides a better representation of the audited page. Which will provide Lighthouse users with more information.

@patrickhulce
Copy link
Collaborator

I'm not sure about all the attributes but property definitely sounds good! I'd welcome such a PR :)

@connorjclark
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants