core(artifacts): add property attribute to MetaElements #9978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks good, thanks! could you also add a meta element to one of our smoke tests ( |
|
@connorjclark Thanks for the tip, fixed it! |
connorjclark
requested changes
Nov 20, 2019
| @@ -25,6 +25,7 @@ class MetaElements extends Gatherer { | |||
| return { | |||
| name: meta.name.toLowerCase(), | |||
| content: meta.content, | |||
| property: meta.attributes.property ? meta.attributes.property.value : '', | |||
There was a problem hiding this comment.
this should be undefined instead of '' when not found
There was a problem hiding this comment.
I was in doubt about this, because content is '', also if it's not defined. So I kept it in line. But since property isn't in the HTML5 spec, I understand your comment as well.
connorjclark
approved these changes
Nov 20, 2019
connorjclark
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The MetaElements artifacts contains now also de meta element attribute
property. Now only thenameattribute was present. Thepropertyattribute is often use by Open Graph meta tags. More information aboutproperty: https://stackoverflow.com/questions/22350105/whats-the-difference-between-meta-name-and-meta-propertyRelated Issues/PRs
Fixes #9964