Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: add ids to gatherers #10187

Closed
wants to merge 1 commit into from
Closed

core: add ids to gatherers #10187

wants to merge 1 commit into from

Conversation

connorjclark
Copy link
Collaborator

closes #2087

I suppose description would only be used when we print the status.

image

Do we especially want that, or do we just want an id instead of using the classname?

@patrickhulce
Copy link
Collaborator

I don't think this should live on the gatherer implementation. The grand unified view in the brain of me was that audits and gatherers have implementations that are id-agnostic, the config then creates an audit or gatherer instance by taking the implementation with a set of options and that instance has an id that can be referenced. This was the incarnation of audit/gatherer IDs that would've closed #2087 IMO --> #8374

If the id lives on the implementation then it doesn't really seem any different from using the class name like our audits basically do now.

@connorjclark
Copy link
Collaborator Author

alright, i've lost the thread here then. seems like that PR is what should land.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gatherers should have ids
3 participants