Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core(is-on-https): add Mixed Content verbiage to description #10712

Merged
merged 3 commits into from
May 8, 2020

Conversation

Beytoven
Copy link
Contributor

@Beytoven Beytoven commented May 6, 2020

Adding a line about Mixed Content to signal that it's covered by this audit.

@Beytoven Beytoven requested a review from a team as a code owner May 6, 2020 20:02
@Beytoven Beytoven requested review from patrickhulce and removed request for a team May 6, 2020 20:02
lighthouse-core/audits/is-on-https.js Outdated Show resolved Hide resolved
lighthouse-core/audits/is-on-https.js Outdated Show resolved Hide resolved
@connorjclark connorjclark changed the title core(is-on-https): add Mixed Content verbiage to is-on-https audit core(is-on-https): add Mixed Content verbiage to description May 6, 2020
Co-authored-by: Patrick Hulce <patrick.hulce@gmail.com>
@patrickhulce
Copy link
Collaborator

I think it needs a sample json update, but looks good :)

Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @Beytoven! 🎉

@patrickhulce patrickhulce merged commit cfecfea into master May 8, 2020
@patrickhulce patrickhulce deleted the mixed-content-http branch May 8, 2020 19:52
@brendankenny brendankenny mentioned this pull request May 11, 2020
54 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants