-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: move proto roundtrip json to .tmp/ #10995
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah this was an annoyance when I was relying on dependencies and artifacts during experimentation. great change.
although the above is not relevant any more so I agree doing .tmp
makes more semantic sense. even if some other job needs that file ... i'd rather upload tmp as a separate artifact than use dist.
I'll defer my review if @connorjclark has feelings here. I have no strong preference 🤷 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
another vote for .tmp (or wherever that's not dist/).
It shouldn't be a hard and fast rule, but it's nice to keep dist/
to things that are intended to actually be distributed (in one way or the other).
.tmp done |
#6183 added this file and at the time it was tracked in source control
in #10557 we added the file to gitignore
now that it's ignored, seems like it can be in
dist
rather than nestled amongst tracked files.i went withthis makes more semantic sense indist
because #10994 but i suppose if we're not sharing artifacts between builds.... perhaps.tmp
?