core: normalize node information in gathering #11405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
changed the title
types/artifacts.d.ts
Outdated
| @@ -217,6 +218,12 @@ declare global { | |||
| export interface IFrameElement { | |||
| /** The `id` attribute of the iframe. */ | |||
| id: string, | |||
| /** Details for node in DOM for the iframe element */ | |||
There was a problem hiding this comment.
Did we consider making an object for this? ie node: NodeDetails
There was a problem hiding this comment.
Yes! There was a consideration to make a node object, although given that this pr was getting a bit hefty, I am planning on doing so in a separate one.
There was a problem hiding this comment.
sounds good! patricks note re: iframe elements being "public" will be relevant, we can just duplicate the old properties there for now. We'll want to add a note in the #11207 issue to remove them on v7.
adrianaixba
commented
Sep 14, 2020
|
@adrianaixba is this waiting on me now? |
@patrickhulce finishing up on some of your suggestions! still 'waiting4committer' 😁 |
patrickhulce
approved these changes
Sep 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a getNodeInfo function on page-functions that can be easily implemented to current/new element gatherers. This facilitates the addition of the element's node data and helps ensure that any necessary node data may always be consistently included.
Part of the node data included is 'boundingRect', although there are some elements that contain a 'clientRect', it seems as though some of those may be uniquely catered to that gatherer. So, I chose to leave boundingRect as somewhat of a 'standard' rect (would appreciate some input on this!)
Should help facilitate solving #9947