Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc(axe): rename axe types #11432

Merged
merged 2 commits into from
Sep 14, 2020
Merged

misc(axe): rename axe types #11432

merged 2 commits into from
Sep 14, 2020

Conversation

paulirish
Copy link
Member

small tweak.

we use axeResult in two places for two different things. I've renamed both to differentiate more clearly.

  1. in the gatherer to refer to the return value of axe.run().
  2. the artifacts.d.ts type that refers to an individual axe rule's results.
    • I've renamed it to AxeRuleResult to clarify it's just a single axe rule being described. axe-core uses this term, too.

@paulirish paulirish requested a review from a team as a code owner September 14, 2020 16:40
@paulirish paulirish requested review from adamraine and removed request for a team September 14, 2020 16:40
Copy link
Member

@adamraine adamraine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devtools-bot devtools-bot merged commit 11cf91a into master Sep 14, 2020
@devtools-bot devtools-bot deleted the axeruleresult branch September 14, 2020 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants