Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps(inquirer): upgrade to 7.3.3 #11441

Merged
merged 1 commit into from
Sep 17, 2020
Merged

deps(inquirer): upgrade to 7.3.3 #11441

merged 1 commit into from
Sep 17, 2020

Conversation

connorjclark
Copy link
Collaborator

part of #10404

fixes 2 of the 5 high severity issues

@connorjclark connorjclark requested a review from a team as a code owner September 16, 2020 22:18
@connorjclark connorjclark requested review from adamraine and removed request for a team September 16, 2020 22:18
@brendankenny
Copy link
Member

I don't think we have any tests for the inquirer integration, so should manually check it's not automatically enrolling in error reporting due to switching to promises or something.

@brendankenny
Copy link
Member

(but this PR also isn't updating lodash)

@brendankenny
Copy link
Member

brendankenny commented Sep 16, 2020

yarn has actually been lazy here:

lighthouse/yarn.lock

Lines 5559 to 5567 in 039b6c6

lodash@^4.0.0, lodash@^4.1.0, lodash@^4.13.1, lodash@^4.17.10, lodash@^4.17.11, lodash@^4.17.3, lodash@^4.17.4, lodash@^4.2.1, lodash@^4.3.0:
version "4.17.14"
resolved "https://registry.yarnpkg.com/lodash/-/lodash-4.17.14.tgz#9ce487ae66c96254fe20b599f21b6816028078ba"
integrity sha512-mmKYbW3GLuJeX+iGP+Y7Gp1AiGHGbXHCOh/jZmrawMmsE7MS4znI3RL2FsjbqOyMayHInjOeykW7PEajUk1/xw==
lodash@^4.17.14, lodash@^4.17.15, lodash@^4.17.19:
version "4.17.19"
resolved "https://registry.yarnpkg.com/lodash/-/lodash-4.17.19.tgz#e48ddedbe30b3321783c5b4301fbd353bc1e4a4b"
integrity sha512-JNvd8XER9GQX0v2qJgsaN/mzFCNA5BRe/j8JN9d+tWyGLSodKQHKFicdwNYzWwI3wjRnaKPsGj1XkBjx/F96DQ==

if you delete these lines and re-run yarn it'll converge on a single version of 4.17.20 and no need to risk inquirer updates (if you don't want to).

@connorjclark
Copy link
Collaborator Author

Oh, I did test it manually. You just have to delete the configstore check in sentry-prompt. still works the same.

@brendankenny
Copy link
Member

Oh, I did test it manually. You just have to delete the configstore check in sentry-prompt. still works the same.

yes, no, and timeout? :D

@connorjclark
Copy link
Collaborator Author

didn't think to test timeout, just did that now, yup all good.

Copy link
Member

@adamraine adamraine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@connorjclark connorjclark merged commit d4fc00c into master Sep 17, 2020
@connorjclark connorjclark deleted the deps-inquirer branch September 17, 2020 21:52
@brendankenny
Copy link
Member

(but this PR also isn't updating lodash)

y'all... :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants