-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps(inquirer): upgrade to 7.3.3 #11441
Conversation
I don't think we have any tests for the inquirer integration, so should manually check it's not automatically enrolling in error reporting due to switching to promises or something. |
(but this PR also isn't updating lodash) |
yarn has actually been lazy here: Lines 5559 to 5567 in 039b6c6
if you delete these lines and re-run |
Oh, I did test it manually. You just have to delete the configstore check in |
yes, no, and timeout? :D |
didn't think to test timeout, just did that now, yup all good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
y'all... :) |
part of #10404
fixes 2 of the 5 high severity issues