Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new_audit(document compatibility check for quirks mode): added #12944

Closed
wants to merge 1 commit into from
Closed

new_audit(document compatibility check for quirks mode): added #12944

wants to merge 1 commit into from

Conversation

k99sharma
Copy link
Contributor

@k99sharma k99sharma commented Aug 19, 2021

Summary

Type of PR
Additional condition checking

Need for change
Lighthouse overlooked compatibility check for quirks mode in case of incorrect doctype. I added an additional check for compatibility with an additional explanation message explanationWrongDoctype in UIStrings.

Screenshot (169)

Screenshot (168)

Documentation
I looked at this: compatMode MDN doc for more information about compatibility check.

Related Issues/PRs
PR to fix the issue no: #10030

And sorry for the extra changes my IDE automatically converted single quotes into double quotes

- added new explanation string in `UIStrings` as `explanationWrongDoctype`
- added new `if` statement to check `document.compatMode`
@k99sharma k99sharma requested a review from a team as a code owner August 19, 2021 20:43
@k99sharma k99sharma requested review from connorjclark and removed request for a team August 19, 2021 20:43
@google-cla
Copy link

google-cla bot commented Aug 19, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@k99sharma
Copy link
Contributor Author

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Aug 19, 2021
@k99sharma k99sharma changed the title Fix: Added check for compatibility mode in doctype check new_audit(document compatibility check for quirk mode): added Aug 19, 2021
@k99sharma k99sharma changed the title new_audit(document compatibility check for quirk mode): added new_audit(document compatibility check for quirks mode): added Aug 19, 2021
@k99sharma k99sharma closed this Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants