-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: fix crash with Sentry init #13104
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
worked on v12 and v16 👍
I run into an unrelated issue on v14 though, does anyone else?
file:///Users/patrick/Code/OpenSource/lighthouse/lighthouse-cli/cli-flags.js:15
import {isObjectOfUnknownValues} from '../lighthouse-core/lib/type-verifiers.js';
^^^^^^^^^^^^^^^^^^^^^^^
SyntaxError: The requested module '../lighthouse-core/lib/type-verifiers.js' is expected to be of type CommonJS, which does not support named exports. CommonJS modules can be imported by importing the default export.
For example:
import pkg from '../lighthouse-core/lib/type-verifiers.js';
const {isObjectOfUnknownValues} = pkg;
Try the lastest 14? |
works for me in 14.15 (first LTS), 14.16.1, and 14.17.6 (latest LTS) |
Alright, then 🤷 (works on latest LTS for me as well) |
ah, were you running < 14.13? That's when nodejs/node#35249 landed. Makes our
increasingly untrue :/ |
Yeah, I was running 14.8. The matrix of versions that support Lighthouse as a consumer now feels dangerously close to a breaking version change :/ |
fixes #13101
Co-authored-by: Yorkie Liu yorkiefixer@gmail.com