Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: always return correct version #13130

Merged
merged 1 commit into from
Sep 27, 2021
Merged

cli: always return correct version #13130

merged 1 commit into from
Sep 27, 2021

Conversation

patrickhulce
Copy link
Collaborator

Summary
For some reason in our published bundle, version doesn't work. To repro...

docker run -it --user root --entrypoint /bin/bash node:14-buster
$ npm install -g lighthouse
$ lighthouse --version
unknown

Sadly this doesn't actually repro within our repo, so testing is rough, but manually applying this patch to an install in the docker container had the intended effect.

Related Issues/PRs
fixes #13129

@patrickhulce patrickhulce requested a review from a team as a code owner September 27, 2021 22:08
@patrickhulce patrickhulce requested review from adamraine and removed request for a team September 27, 2021 22:08
@google-cla google-cla bot added the cla: yes label Sep 27, 2021
@patrickhulce patrickhulce merged commit 1c1514d into master Sep 27, 2021
@patrickhulce patrickhulce deleted the fix_version branch September 27, 2021 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version is broken ~8.5.0 release
4 participants