Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

report(test): split out axe test #13142

Merged
merged 1 commit into from
Sep 29, 2021
Merged

Conversation

paulirish
Copy link
Member

no changes other than splitting this test into its own file.

Since this thing takes 40s+, I personally want it separate so I can know that the REST of report-renderer-test is passing without waiting for this bigguy.

and while the yarn unit-report --watch will still be slow.... with this change, i'll happily run this instead: yarn jest $(find report -iname "*-test.js" | grep -v axe) --watch.

(of course, i'm also hoping to move this test to a karma/mocha setup at some point, but i don't have the time for that atm)

@paulirish paulirish requested a review from a team as a code owner September 29, 2021 23:31
@paulirish paulirish requested review from connorjclark and removed request for a team September 29, 2021 23:31
@google-cla google-cla bot added the cla: yes label Sep 29, 2021
Copy link
Collaborator

@connorjclark connorjclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was really hoping jest simply had a skipTestCase flag, but lacking that, this change is fine.

@brendankenny
Copy link
Member

brendankenny commented Sep 29, 2021

(of course, i'm also hoping to move this test to a karma/mocha setup at some point, but i don't have the time for that atm)

I mentioned one way back in #9421 (comment): if we're willing to put yarn build-sample-reports in the prereqs for smoke tests, we have a far better way to run axe against reports than using jsdom (which only supports a subset of the real report in a real browser anyways), it'll be faster than 40s, and we can easily also audit the error report, reports in other locales, maybe extend it to catch perf regressions of the report, etc :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants