tests: centralize running of recipe tests #13150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendankenny
requested review from
connorjclark
and removed request for
a team
brendankenny
commented
Sep 30, 2021
| "install-all": "yarn --cwd auth/ && yarn --cwd integration-test/ && yarn --cwd custom-gatherer-puppeteer/", | ||
| "integration-test": "yarn --cwd integration-test/ jest --config-path=docs-jest.config.js", | ||
| "custom-gatherer-puppeteer-test": "yarn --cwd custom-gatherer-puppeteer/ test", | ||
| "test": "yarn install-all && yarn integration-test && yarn custom-gatherer-puppeteer-test" |
There was a problem hiding this comment.
a little weird to run install-all under test, but since the only reason you'd ever run install-all (as opposed to installing just the single recipe you're looking at) is to run the tests, it seems fine? 🤷
| coveragePathIgnorePatterns: [ | ||
| '/test/', | ||
| '/scripts/', | ||
| ], |
There was a problem hiding this comment.
these lines haven't been used for a loooooooong time
connorjclark
approved these changes
Sep 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kind of a prerequisite to #13148, but useful on its own.
The recipes each need their own
yarn installrun (and it turns outintegration-testdidn't have itsinstallrun, it was just falling back to the rootjestand (I believe) theyarn linkedlighthouse).As a result it doesn't really make sense to include
docs/recipes/integration-test/example-lh-auth.test.jsin the default jest tests, which ideally should work with just agit clone ... && yarn && yarn build-all && yarn test.This PR breaks it out into its own separate
jestcall, and centralizes the running of the recipe tests to their ownpackage.json.