Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc: rename lighthouse-cli to cli #13302

Closed
wants to merge 2 commits into from
Closed

misc: rename lighthouse-cli to cli #13302

wants to merge 2 commits into from

Conversation

connorjclark
Copy link
Collaborator

No description provided.

@connorjclark connorjclark requested a review from a team as a code owner November 2, 2021 00:53
@connorjclark connorjclark requested review from adamraine and removed request for a team November 2, 2021 00:53
@google-cla google-cla bot added the cla: yes label Nov 2, 2021
@connorjclark connorjclark mentioned this pull request Nov 2, 2021
Closed
@brendankenny
Copy link
Member

This might be worth talking about in the meeting today.

A lot of tools reach pretty far into Lighthouse and so this and the core rename might be the biggest breaking change of 9.0 by far. That's not necessarily a blocker, but since this isn't a refactor to gain anything, we should strongly consider just living with our naming mistakes of the distant past rather than asking everyone to take on work so we can rename a directory.

@connorjclark connorjclark mentioned this pull request Nov 11, 2021
Closed
@paulirish paulirish closed this Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamraine adamraine adamraine approved these changes

Assignees

@adamraine adamraine

Labels
cla: yes waiting4reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@connorjclark @brendankenny @adamraine @paulirish @devtools-bot