Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc(build): do not assign runBundledLighthouse in devtools bundle #13311

Merged
merged 8 commits into from
Nov 9, 2021
Merged

misc(build): do not assign runBundledLighthouse in devtools bundle #13311

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0272e14
misc(build): do not assign runBundledLighthouse in devtools bundle
connorjclark Nov 3, 2021
c7475ef
Merge remote-tracking branch 'origin/master' into dt-build-globalthis
connorjclark Nov 3, 2021
ee431b1
Merge branch 'master' into dt-build-globalthis
connorjclark Nov 3, 2021
0c426f0
Merge branch 'master' into dt-build-globalthis
connorjclark Nov 4, 2021
60e2d20
fix
connorjclark Nov 4, 2021
2d69e54
Merge branch 'dt-build-globalthis' of github.com:GoogleChrome/lightho…
connorjclark Nov 4, 2021
5271aa5
Merge remote-tracking branch 'origin/master' into dt-build-globalthis
connorjclark Nov 4, 2021
2e78bb1
Merge branch 'master' into dt-build-globalthis
connorjclark Nov 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 4 additions & 10 deletions clients/devtools-entry.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,16 +78,6 @@ function lookupCanonicalLocale(locales) {
return lookupLocale(locales, getCanonicalLocales());
}

// For the bundle smoke test.
if (typeof module !== 'undefined' && module.exports) {
// Ideally this could be exposed via browserify's `standalone`, but it doesn't
// work for LH because of https://github.com/browserify/browserify/issues/968
// Instead, since this file is only ever run in node for testing, expose a
// bundle entry point as global.
// @ts-expect-error
global.runBundledLighthouse = lighthouse;
}

// Expose only in DevTools' worker
if (typeof self !== 'undefined') {
// TODO: refactor and delete `global.isDevtools`.
Expand All @@ -106,4 +96,8 @@ if (typeof self !== 'undefined') {
// TODO: expose as lookupCanonicalLocale in LighthouseService.ts?
// @ts-expect-error
self.lookupLocale = lookupCanonicalLocale;
} else {
// For the bundle smoke test.
// @ts-expect-error
global.runBundledLighthouse = lighthouse;
}