deps: update transitive deps to quiet vulnerability alerts #13538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendankenny
requested review from
connorjclark
and removed request for
a team
brendankenny
commented
Jan 4, 2022
Comment on lines
-98
to
-100
| "@firebase/app-types": "0.3.1", | ||
| "@firebase/auth-types": "0.3.2", | ||
| "@firebase/util": "0.2.1", |
There was a problem hiding this comment.
I believe these were a merge error. Removed when firebase was updated for Viewer in #13115, but added back in #12771. Could not figure out what part of the rollup process they were for, until I remembered that was just a long-lived PR and those lines probably just snuck back in. cc @connorjclark just in case
brendankenny
commented
Jan 4, 2022
| @@ -8522,28 +8375,18 @@ write-file-atomic@^3.0.0: | |||
| signal-exit "^3.0.2" | |||
| typedarray-to-buffer "^3.1.5" | |||
|
|
|||
| ws@7.4.6, ws@^7.0.0, ws@^7.4.5: | |||
| ws@7.4.6, ws@>=7.4.6, ws@^7.0.0, ws@^7.3.1, ws@^7.4.5: | |||
There was a problem hiding this comment.
actual dep ws@^7.0.0 wasn't changed here
connorjclark
approved these changes
Jan 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are all from devDeps, so not a big deal, but a lot have built up. There's one remaining, tracked in sindresorhus/cpy#98 (nobody pass a pathological regex while copying over extension files to
dist/!).Separated by commit just in case someone cares :)