Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: split devtools ci into build, web-tests and smoke jobs #13546

Merged
merged 28 commits into from
Jan 7, 2022

Conversation

connorjclark
Copy link
Collaborator

  • adds a build job, which rolls LH + builds devtools and uploads to GHA as an artifact
  • adds web-tests and sharded smoke test jobs
  • uses restore-keys for actions/cache step, which should speed up build times for cache-misses

cache hit:

image

cache miss (building off latest cache):

(don't have an example here yet lol)

Building from scratch (no cache used at all):

image

@connorjclark connorjclark requested a review from a team as a code owner January 7, 2022 01:11
@connorjclark connorjclark requested review from adamraine and removed request for a team January 7, 2022 01:11
.github/workflows/devtools.yml Show resolved Hide resolved
@@ -6,7 +6,7 @@ on:
pull_request: # run on all PRs, not just PRs to a particular branch

jobs:
integration:
build:
runs-on: macos-latest # while macbots are much slower, linux reliably crashes running this
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this still the case? there are a ton more Linux bots than there are Mac bots...in theory we'll be competing with other google or googlechrome projects for these

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It didn't work locally on my linux machine. I can poke at it more later.

Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

.github/workflows/devtools.yml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants