Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update robots-parser to latest #13554

Merged
merged 1 commit into from
Jan 11, 2022
Merged

deps: update robots-parser to latest #13554

merged 1 commit into from
Jan 11, 2022

Conversation

brendankenny
Copy link
Member

Follow up to #13545 (comment)

robots-parser published the change to use the global URL, so that can be removed from the url shim TODO.

robots-parser 2.4.0 also added typedefs, so we can remove ours! Only issue is that they're written for an ESM future (export default callableFunction) and we're still in commonjs land. Rather than upstream a fix (which can be contentious depending on where you're coming from, see e.g. this epic thread), it seems fine to work around with a typecast plus a TODO(esmodules) since

  • it's a cast to its own type
  • esmodules are coming
  • we get to get rid of a whole d.ts file
  • when esmodule do come, I don't think we'll remember to ditch this d.ts file then

No functional changes since our previous robots-parser version 2.3.0.

@brendankenny brendankenny requested a review from a team as a code owner January 10, 2022 19:44
@brendankenny brendankenny requested review from connorjclark and removed request for a team January 10, 2022 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants