tests(devtools): ensure WebSQL table is populated #13579
Conversation
| await TestRunner.RuntimeAgent.invoke_evaluate({ | ||
| expression: 'webSqlPromise', | ||
| awaitPromise: true, | ||
| }); |
There was a problem hiding this comment.
I tried fixing this too. I did this:
I was trying to make LH wait for the DB by waiting for first paint.
But... this went from flaky to never seeing the DB usage. I never figured out why.
There was a problem hiding this comment.
ooooh, I see what you've done. You made the DB get initiated before LH even runs. To make that more clear can you move this to right after the navigate?
So how was this ever working before? :)
There was a problem hiding this comment.
So how was this ever working before?
It was flaky, sometimes the row would be added to the table in time, and sometimes it wouldn't. In CI it usually got added in time so I just kinda ignored the problem when it showed up locally.
Toplevel await works in module scripts, but the script itself is loaded asynchronously so there still isn't a guarantee that the row is added to the table before the page loads. I'm not sure if toplevel await is supported like you have it.
There was a problem hiding this comment.
To make that more clear can you move this to right after the navigate?
Move what to the right? Sorry don't understand.
There was a problem hiding this comment.
Not "to the right". "right after" TestRunner.navigatePromise.
There was a problem hiding this comment.
🙃 🙃 🙃 🙃 🙃 🙃 🙃 🙃 🙃 🙃 🙃 🙃 🙃 🙃 🙃 🙃 🙃 🙃 🙃 🙃 🙃 🙃 🙃 🙃 🙃 🙃 🙃 🙃 🙃 🙃 🙃 🙃 🙃 🙃 🙃 🙃 🙃 🙃 🙃 🙃 🙃 🙃
Should prevent the flakiness in DevTools tests.