Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clients: convert devtools and lightrider entries to ES modules #13722

Merged
merged 1 commit into from
Mar 7, 2022

Conversation

connorjclark
Copy link
Collaborator

ref #12689

manually confirmed to work in LR.

@connorjclark connorjclark requested a review from a team as a code owner March 5, 2022 02:18
@connorjclark connorjclark requested review from adamraine and removed request for a team March 5, 2022 02:18
@connorjclark connorjclark mentioned this pull request Mar 5, 2022
17 tasks
mobile: require('../../lighthouse-core/config/lr-mobile-config.js'),
desktop: require('../../lighthouse-core/config/lr-desktop-config.js'),
mobile: mobileConfig,
desktop: desktopConfig,
};

/** @typedef {import('../../lighthouse-core/gather/connections/connection.js')} Connection */

// Rollup seems to overlook some references to `Buffer`, so it must be made explicit.
// (`parseSourceMapFromDataUrl` breaks without this)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just realized there is no smoke test for this. Will add one monday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants