WIP: mocha and lighthouse-core as esm #14167
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested, this combines these two large branches:
mocha-final
tests: replace jest with mocha #14054esm-core
(no PR yet)Some issues cropped up that are still unresolved, but aren't showstoppers. Namely:
lighthouse/lighthouse-core/test/fraggle-rock/gather/navigation-runner-test.js
Line 425 in ce17c7d
lighthouse/lighthouse-core/runner.js
Line 443 in ce17c7d
lighthouse/lighthouse-core/fraggle-rock/gather/navigation-runner.js
Line 108 in ce17c7d