Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: mocha and lighthouse-core as esm #14167

Closed
wants to merge 82 commits into from
Closed

Conversation

connorjclark
Copy link
Collaborator

As requested, this combines these two large branches:

Some issues cropped up that are still unresolved, but aren't showstoppers. Namely:

@connorjclark connorjclark requested a review from a team as a code owner June 29, 2022 00:54
@connorjclark connorjclark requested review from brendankenny and removed request for a team June 29, 2022 00:54
@connorjclark connorjclark marked this pull request as draft June 29, 2022 00:54
@connorjclark
Copy link
Collaborator Author

image

Sigh...

The tests pass locally, I swear. I'm sure they'll pass in CI too...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants