-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: upgrade axe-core
to 4.6.3
#14690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I asked about the changes dequelabs/axe-core#3887 |
adamraine
commented
Jan 25, 2023
role="radiogroup"> | ||
<div></div> | ||
role="list"> | ||
<div>Item</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adamraine
commented
Jan 25, 2023
@@ -190,7 +190,7 @@ <h3>sub-sub-header</h3> | |||
</section> | |||
<p>object-alt</p> | |||
<section> | |||
<object id="object-alt"></object> | |||
<object id="object-alt" data="data:text/html,data"></object> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
connorjclark
changed the title
deps: upgrade
deps: upgrade Jan 25, 2023
axe-core
to 4.6.2axe-core
to 4.6.3
connorjclark
approved these changes
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/dequelabs/axe-core/releases
New rules:
target-size
Seems similar to our tap targets audittap-targets
withtarget-size
rule from Axe and put under Accessibility, not SEO #12345meta-refresh-no-exceptions
Looks like a more strict version ofmeta-refresh
link-in-text-block
Moved out of experimental. I manually disabled it for now.frame-title-unique
is now wcag2a so we pick it up automatically. I manually disabled for now though.There are some smoke failures forobject-alt
andaria-required-children
that I couldn't figure out just looking at the change-log.This should be good now.
cc @jazyan