core(tracing): handle FrameCommittedInBrowser with processPseudoId #14800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamraine
reviewed
Feb 15, 2023
adamraine
approved these changes
Feb 15, 2023
brendankenny
approved these changes
Feb 15, 2023
|
|
||
| const procReadyEvt = JSON.parse(JSON.stringify(fcibEvt)); | ||
| procReadyEvt.name = 'ProcessReadyInBrowser'; | ||
| procReadyEvt.args.data = {frame, processId, processPseudoId: '0xbaabaa'}; |
There was a problem hiding this comment.
Oh, do the processPseudoIds match? Almost feels like information we should be using in trace-processor (only look at ProcessReadyInBrowser events that have a processPseudoId that matches a FrameCommittedInBrowser without a proccessId?) but maybe it can never matter
There was a problem hiding this comment.
yah we definitely could. and I considered it. But I think it's kinda overkill. (tho admittedly OPP does it)
I'm happy to revisit.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #14798
There are some traces where the pid isnt available when the frame is created. In these situations, the
FrameCommittedInBrowserevent has an undefinedprocessIdprop, and empty stringnameprop, and a hexadecimalprocessPseudoId. Later aProcessReadyInBrowserevent provides the processId.I'm not sure how common this is, or the exact circumstances. I've only discovered one of my saved traces (out of 200+) had this pattern, but.. matt ran into it #14798 too.
Regardless, here's a fix w/ a test.