Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new_audit: csp-inline #14878

Closed
wants to merge 6 commits into from
Closed

new_audit: csp-inline #14878

wants to merge 6 commits into from

Conversation

adamraine
Copy link
Member

@adamraine adamraine commented Mar 10, 2023 •
edited
Loading

Closes #13004

Needs https://developer.chrome.com/ doc before we can merge.

@adamraine adamraine requested a review from a team as a code owner March 10, 2023 23:50
@adamraine adamraine requested review from brendankenny and removed request for a team March 10, 2023 23:50
connorjclark
connorjclark reviewed Jun 13, 2023
View reviewed changes
core/audits/csp-inline.js
/** Description of a Lighthouse audit that advises users to avoid putting a CSP in an inline html meta tag. This is displayed after a user expands the section to see more. No character length limits. The last sentence starting with 'Learn' becomes link text to additional documentation. */
description: 'A CSP defined in an inline `<meta>` tag will delay the preload scanner from ' +
'loading resources early. Consider defining all CSPs in http headers if you can. ' +
'[Learn more about defining a CSP in an inline meta tag]()',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

todo: url

@adamraine adamraine mentioned this pull request Jun 29, 2023
Closed
20 tasks
@brendankenny
Copy link
Member

brendankenny commented Jul 17, 2023 •
edited
Loading

We should consider using inline-csp as more of a noun-y audit id, which would better fit the naming guidelines. I was against this in the sync just now, but now I kind of like it better :)

@adamraine adamraine mentioned this pull request Sep 5, 2023
Closed
@adamraine
Copy link
Member Author

Closing see #13004 (comment)

@adamraine adamraine closed this Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@connorjclark connorjclark connorjclark approved these changes

@brendankenny brendankenny Awaiting requested review from brendankenny brendankenny is a code owner automatically assigned from GoogleChrome/lighthouse-hackers

Assignees

@brendankenny brendankenny

Labels
chillin ❄ waiting4reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Audit: Recommend CSP in headers instead of in-HTML
4 participants
@adamraine @brendankenny @connorjclark @devtools-bot