Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: relax node 18 support #15609

Closed
wants to merge 1 commit into from
Closed

misc: relax node 18 support #15609

wants to merge 1 commit into from

Conversation

paulirish
Copy link
Member

@paulirish paulirish commented Nov 14, 2023

#15290 touched this last

but my cloudtop runs 18.13.0 right now and can't upgrade farther.

fixing this is one of the things that will get the autoroll back again

@paulirish paulirish requested a review from a team as a code owner November 14, 2023 19:56
@paulirish paulirish requested review from adamraine and removed request for a team November 14, 2023 19:56
@adamraine
Copy link
Member

Did you verify that yarn unit runs fine on that node version?

@connorjclark
Copy link
Collaborator

if just for installing there is a setting to ignore this engine field: https://stackoverflow.com/questions/45088031/how-to-ignore-incompatible-engine-node-error-on-installing-npm-dependencies-wi

if this is preventing you from running, maybe using node directly rather than yarn/npm run would avoid any check.

Alt: in the autoroll script let's cut out this engine field.

Assuming that the tests fail on this lower version, you'll need to do above instead

@connorjclark
Copy link
Collaborator

we didn't write down specifically why this is the min version (see #15290 (comment) )

@paulirish
Copy link
Member Author

if just for installing there is a setting to ignore this engine field: stackoverflow.com/questions/45088031/how-to-ignore-incompatible-engine-node-error-on-installing-npm-dependencies-wi

this works for me. i'll just set that in the autoroll scripts. cl/582402660

@paulirish paulirish closed this Nov 14, 2023
@paulirish
Copy link
Member Author

paulirish commented Nov 14, 2023

Did you verify that yarn unit runs fine on that node version?

it does exit with 0 though i do see some snapshot failures... :/ investigating...
nvm i have a stupid alias for 'yarn' and its not passing along exit code...

and smokes had these 2 failures:
image

but i havent run these on main in a long time so... no idea if my machine is off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants