Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(dbw): revert expectations for unload handler removal #15802

Merged
merged 2 commits into from
Feb 5, 2024
Merged

tests(dbw): revert expectations for unload handler removal #15802

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e5b00e
Revert "tests(dbw): update expectations for unload handler removal (#…
adamraine Feb 5, 2024
870c40a
oopif scripts
adamraine Feb 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 3 additions & 18 deletions cli/test/smokehouse/test-definitions/dobetterweb.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,8 +208,6 @@ const expectations = {
},
],
GlobalListeners: [{
// Unload handlers were disabled in M122
_maxChromiumVersion: '121',
type: 'unload',
scriptId: /^\d+$/,
lineNumber: '>300',
Expand Down Expand Up @@ -308,13 +306,6 @@ const expectations = {
description: 'Failed to load resource: the server responded with a status of 404 (Not Found)',
sourceLocation: {url: 'http://localhost:10200/favicon.ico'},
},
{
// Unload handlers were disabled in M122
_minChromiumVersion: '122',
source: 'violation',
description: 'Permissions policy violation: unload is not allowed in this document.',
sourceLocation: {url: 'http://localhost:10200/dobetterweb/dbw_tester.html'},
},
],
},
},
Expand Down Expand Up @@ -387,10 +378,7 @@ const expectations = {
subItems: undefined,
},
{
// Deprecation warning was added in M121
_minChromiumVersion: '121',
// Unload handlers were disabled in M122
_maxChromiumVersion: '121',
value: 'UnloadHandler',
source: {
type: 'source-location',
Expand Down Expand Up @@ -492,8 +480,6 @@ const expectations = {
},
},
'no-unload-listeners': {
// Unload handlers were disabled in M122
_maxChromiumVersion: '121',
score: 0,
details: {
items: [{
Expand All @@ -511,8 +497,6 @@ const expectations = {
details: {
items: [
{
// Unload handlers were disabled in M122
_maxChromiumVersion: '121',
reason: 'The page has an unload handler in the main frame.',
failureType: 'Actionable',
subItems: {
Expand All @@ -522,8 +506,9 @@ const expectations = {
},
},
{
// Unload handlers create a permission request in M122
_minChromiumVersion: '122',
// This issue only appears in the DevTools runner for some reason.
// TODO: Investigate why this doesn't happen on the CLI runner.
_runner: 'devtools',
reason: 'There were permission requests upon navigating away.',
failureType: 'Pending browser support',
subItems: {
Expand Down
8 changes: 4 additions & 4 deletions cli/test/smokehouse/test-definitions/oopif-scripts.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,14 +107,14 @@ const expectations = {
source: 'network',
},
{
// Worker requests emitted on the worker's parent target since M121.
_minChromiumVersion: '121',
// Worker requests emitted on the worker's parent target since M123.
_minChromiumVersion: '123',
src: 'http://localhost:10200/simple-worker.mjs',
source: 'network',
},
{
// Worker requests emitted on the worker's parent target since M121.
_minChromiumVersion: '121',
// Worker requests emitted on the worker's parent target since M123.
_minChromiumVersion: '123',
src: 'http://localhost:10200/simple-worker.js',
source: 'network',
},
Expand Down
Loading