Adds full report to CLI and extension. #206
Conversation
| it('has no aggregators failing when shortName is called', () => { | ||
| return walkTree.then(aggregators => { | ||
| aggregators.forEach(aggregator => { | ||
| assert.doesNotThrow(_ => aggregator.shortName); |
There was a problem hiding this comment.
when would accessing a property ever cause a throw (unless you are testing that aggregator is always defined)? or am I missing something :)
There was a problem hiding this comment.
I'm confirming that all aggregators define a shortName, as the report uses it for the menu and to generate the anchor, e.g. #addtohomescreen.
There was a problem hiding this comment.
ah we should use .ok
https://nodejs.org/api/assert.html#assert_assert_ok_value_message
or doesNotEqual undefined then
There was a problem hiding this comment.
Well the base class for Aggregator throws. All we want to check is that they've overridden it in some way. I guess we could .ok as an inverse.
| --mobile Emulates a Nexus 5X (default=true) | ||
| --load-page Loads the page (default=true) | ||
| --output How to output the page(default=pretty) |
There was a problem hiding this comment.
we'll need better docs for this, but 👍 for now
|
Looking good. A few minor things, but the major things remaining are the filename for the outputted file and if we can just have a single |
|
Ack on the filename bug, and I could unify the report classes, but the paths aren't the same. |
|
All done, and added some extra gubbins (with tests) for the printer. PTAL. |
|
FYI changes now include:
This means we can generate any type of output and either push it to I'm not doing any path friendliness to make sure that the output directory exists. We can definitely do this, but this PR is already big enough. |
| } | ||
|
|
||
| getReportHTML() { | ||
| return fs.readFileSync(path.join(__dirname, './templates/report.html'), 'utf8'); |
|
should really have held off on Printer refactor for a separate PR :P I really want to land this today, but is it too late there for additional changes? |
| */ | ||
| set outputMode(mode) { | ||
| if (Printer._outputModes.indexOf(mode) === -1) { | ||
| console.warn(`Unknown output mode ${mode}; using pretty`); |
There was a problem hiding this comment.
probably want the npmlog dance for these console.warn lines?
|
Brendan is taking over this PR |
|
closing this in favor of #225 |
No description provided.