Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed incorrect comments #2392

Merged
merged 1 commit into from
May 30, 2017
Merged

fixed incorrect comments #2392

merged 1 commit into from
May 30, 2017

Conversation

mixed
Copy link
Contributor

@mixed mixed commented May 30, 2017

When I build fail, I saw below message. I think that below comment is wrong.

yarn install; yarn build;

@patrickhulce
Copy link
Collaborator

ah, the commands to run depend on which directory you're in @mixed :)
It's true the more common case will likely be running into this issue when developing lighthouse core rather than just chrome-launcher. We could also alias 'install-launcher' and 'build-launcher' in the launcher repo to run the regular commands, haha. thoughts @samccone?

@mixed
Copy link
Contributor Author

mixed commented May 30, 2017

Thanks @patrickhulce

I got it. :) I ran into the root folder and met the message. If I ran it in the chrome-launcher folder, it would not have been a problem. If so, I hope that it will be modified as well.

Copy link
Member

@paulirish paulirish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paulirish paulirish merged commit ca7d066 into GoogleChrome:master May 30, 2017
paulirish pushed a commit to GoogleChrome/chrome-launcher that referenced this pull request Aug 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants