extract logger from lighthouse #2528
Conversation
samccone
force-pushed
the
extract-logger
branch
4 times, most recently
from
f6f9bf5
to
7c74318
Compare
| @@ -13,7 +13,7 @@ import {DEFAULT_FLAGS} from './flags'; | |||
| import {makeTmpDir, defaults, delay} from './utils'; | |||
| import * as net from 'net'; | |||
| const rimraf = require('rimraf'); | |||
| const log = require('lighthouse/lighthouse-core/lib/log'); | |||
| const log = require('lighthouse-logger'); | |||
There was a problem hiding this comment.
oh boy haha, can we just grab the lighthouse org instead? 😃
require('@lighthouse/logger')require('@lighthouse/chrome-launcher')require('@lighthouse/all-the-things')
There was a problem hiding this comment.
https://www.npmjs.com/org/lighthouse looks like it's already taken, but no one is using it...
There was a problem hiding this comment.
maybe we should use @____lighthouse as an org 😛 I believe it would 🚀 our npm installs as it's so easy to type (#sarcasm)
| @@ -83,7 +83,6 @@ gulp.task('browserify', () => { | |||
| removeComments: true | |||
| }) | |||
| .transform('brfs') | |||
| .ignore('../lighthouse-core/lib/log.js') | |||
There was a problem hiding this comment.
think viewer still wants to omit logger from the brfs output.
.ignore('../lighthouse-logger/index.js')?
There was a problem hiding this comment.
think viewer still wants to omit logger from the brfs output.
FWIW, this is just a bundle-size optimization that won't matter after viewer switches to LH2 in #2521
There was a problem hiding this comment.
updated per @ebidel's comment
| version "6.22.0" | ||
| resolved "https://registry.yarnpkg.com/babel-code-frame/-/babel-code-frame-6.22.0.tgz#027620bee567a88c32561574e7fd0801d33118e4" | ||
| dependencies: | ||
| chalk "^1.1.0" | ||
| esutils "^2.0.2" | ||
| js-tokens "^3.0.0" | ||
|
|
||
| babel-core@^6.0.2, babel-core@^6.23.0: |
There was a problem hiding this comment.
yargs and babel-core removed from this lockfile. I guess it was just stale?
| @@ -632,6 +632,12 @@ debug@2.2.0, debug@^2.1.1, debug@^2.2.0: | |||
| dependencies: | |||
| ms "0.7.1" | |||
|
|
|||
| debug@^2.6.8: | |||
There was a problem hiding this comment.
you're bumping to latest debug with this change, yes?
|
Thanks y'all |
Fixes #2526