CRC audit: child chain renders using its own transfersize. Fixes #2597 #2610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| assert.equal(chains[1].querySelector('.crc-node__tree-hostname').textContent, '(example.com)'); | ||
| const durationNodes = chains[1].querySelectorAll('.crc-node__chain-duration'); | ||
| assert.equal(durationNodes[0].textContent, ' - 5,000ms, '); | ||
| assert.equal(durationNodes[1].textContent, '1.95KB'); |
There was a problem hiding this comment.
maybe put a comment/assertion message that this is the transferSize and 2000 bytes is being formatted to KB? Took me a little while to see where it came from/if the new transfer sizes were being tested.
|
sorry this'll need a rebase for the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Children chains were using the overall
longestChain.transferSizeinstead of their own size.Also updated the renderer test to actually be useful.
Fixes #2597