track number of completed requests in total-byte-weight extendedInfo #2697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickhulce
approved these changes
Jul 17, 2017
|
Yeah I was thinking total-byte-weight instead of critical-request-chains because it's not just priority requests, but I also don't have a strong preference, so if anyone does, speak up soon! :) |
paulirish
approved these changes
Jul 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AFAICT we don't record the raw number of network requests made by a page anywhere, since the total-byte-weight array of assets is limited to the top 10.
There are some interesting patterns with that number, apparently regardless of content/size of the requests (though details there may offer even more interesting stuff). The pattern doesn't end at 10, which is as far as the array length will reveal, so this keeps the raw number around in the
extendedInfo(neatly sidestepping the central question of #2668 for now :) so the investigation can continue.If we do record that number in the report, let me know and we can close instead.