Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add license to lighthouse-logger. #2846

Merged
merged 1 commit into from
Aug 4, 2017
Merged

Conversation

samccone
Copy link
Contributor

@samccone samccone commented Aug 4, 2017

No description provided.

@mikesherov
Copy link

Thank you!

@brendankenny
Copy link
Member

is the LICENSE file necessary with one at the repo root? Or is this to make sure it's in the npm module? If so, should we add one to chrome-launcher as well?

@samccone
Copy link
Contributor Author

samccone commented Aug 4, 2017

If someone consumes this module directly then yes for those users it is needed.

@paulirish paulirish merged commit 367ea7a into master Aug 4, 2017
@paulirish paulirish deleted the sjs/add-license-to-logger branch August 4, 2017 19:53
@mikesherov
Copy link

Just as FYI, either LICENSE file or license field works for my use case, which is we use license-to-fail to autoscan our deps and fail builds on it and that tool looks in NPM license field or for LICENSE file

@mikesherov
Copy link

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants