add flag to FMP to indicate if it fell back to FMP candidate #2851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulirish
requested changes
Aug 5, 2017
| @@ -69,13 +69,15 @@ class TraceOfTab extends ComputedArtifact { | |||
| let firstMeaningfulPaint = frameEvents.find( | |||
| e => e.name === 'firstMeaningfulPaint' && e.ts > navigationStart.ts | |||
| ); | |||
| let fmpIsFallback = false; | |||
paulirish
approved these changes
Aug 5, 2017
😢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there's no way to tell from the LH results that
trace-of-tabfell back to afirstMeaningfulPaintCandidateevent for the FMP event. #2420 will generate a Sentry entry for that case, but it would be handy to have it in the report so that e.g. the HTTPArchive data can be queried to get frequency numbers on this as well.Happy to bikeshed on this and/or change so that it will also work for logging when/if we turn on #2244