core(devtools-model): fix missing Runtime.experiments object
#3514
Conversation
paulirish
changed the title
Runtime.experiments
paulirish
changed the title
Runtime.experiments Runtime.experiments
paulirish
changed the title
Runtime.experiments
paulirish
changed the title
Runtime.experiments object
paulirish
changed the title
Runtime.experiments objectRuntime.experiments obj
paulirish
changed the title
Runtime.experiments objRuntime.experiments object
| this._timelineModel.setEvents(this._tracingModel); | ||
| ConsoleQuieter.unmuteAndFlush(); | ||
| try { | ||
| ConsoleQuieter.mute({prefix: 'timelineModel'}); |
There was a problem hiding this comment.
what does this do?
any console messages that are absorbed are later logged with that as the logger prefix/title
There was a problem hiding this comment.
oh I didn't mean this particular line, just why is this try/finally necessary now? we're not catching anything the connection to the mocha failure isn't clear to me, so here to learn :)
There was a problem hiding this comment.
Previous to this patch landing, when you run mocha lighthouse-core/test/lib/traces/devtools-timeline-model-test.js it just exits silently. That's because console-quieter was also muting the logs from mocha. They never got flushed (the finally) because of an exception.
There was a problem hiding this comment.
oh gotchaaaa, mocha really just calls console.log? I see
There was a problem hiding this comment.
yah it does. found that this morning. was kinda surprised they aren't doing process.std*.write(), but yeah. :)
|
we should really make it a P0 to fix or disable appveyor so we can trust checks and require green before merging again |
having all of Lighthouse follow |
isn't appveyor fixed with #3498 now? It would be nice if the appveyor badge in the readme linked to the latest master build and not just the latest build, though... |
it is, but I'm talking about appveyor breakages in general. I'm betting Paul fell into my similar camp of "since all the builds are always red anyhow, this red build telling me I shouldn't merge is meaningless, so I'm just gonna merge now" if red builds weren't pretty regularly crying wolf, then we'd be more likely to investigate and postpone a merge because of a red build |
ah, got it, yes definitely agree |
yarn testbreakage on master due to changes in web-inspector: fall back to page's Runtime and queryParam() #3497